fix(sdk): Add required auth scopes to RegistryClient for GCP service accounts credentials #10819
Conversation
|
Hi @PChambino. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The scopes are defined in registry context file. Additional scopes must be comma separated. Fixes kubeflow#8878. Previous PR kubeflow#8895 was approved, but tests failed and became stale. I fixed the tests, and confirmed it worked for my case. Using a GCP Service Account with RegistryClient no longer needs me to explicitly provide the required scopes. Signed-off-by: Pedro Chambino <pchambino@gmail.com>
PChambino
force-pushed
the
sdk-kfp-registry-client-google-auth-scopes
branch
from
4492b38
to
9aa3bd1
Compare
|
/ok-to-test |
|
@PChambino: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@hbelmiro Thanks! I am pretty sure the failing tests are unrelated. They don't seem to be using the RegisteryClient and they fail for me when running them locally on the main branch too. We can see them failing for this recent PR #10750 as well which was merged two weeks ago. So this shouldn't be a blocker but can you confirm or should we ping the sdk/codeowners? |
|
Even though test failure is a non-blocker, it's better check with sdk owners to inspect. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The scopes are defined in registry context file. Additional scopes must be comma separated.
Fixes #8878. Previous PR #8895 was approved, but tests failed and became stale.
I fixed the tests, and confirmed it worked for my case. Using a GCP Service Account with RegistryClient no longer requires me to explicitly provide the required scopes.
Checklist: