fix: make sure node is drained before rebooting when rebootDelay is g… #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reater than 0 Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
|
I've added some concerns in the original issue #929. Let's definitely figure out how to solve for this scenario, but I'm not sure that a second drain operation after the retry wait is the right solution. |
evrardjp
requested changes
May 13, 2024
| @@ -788,6 +788,18 @@ func rebootAsRequired(nodeID string, booter reboot.Reboot, sentinelCommand []str | |||
| if rebootDelay > 0 { | |||
| log.Infof("Delaying reboot for %v", rebootDelay) | |||
| time.Sleep(rebootDelay) | |||
|
|
|||
There was a problem hiding this comment.
I don't think it make sense to add this conditionally on reboot delay.
| @@ -788,6 +788,18 @@ func rebootAsRequired(nodeID string, booter reboot.Reboot, sentinelCommand []str | |||
| if rebootDelay > 0 { | |||
| log.Infof("Delaying reboot for %v", rebootDelay) | |||
| time.Sleep(rebootDelay) | |||
|
|
|||
| log.Infof("Making sure %s is drained before reboot", node.GetName()) | |||
| err = drain(client, node) | |||
There was a problem hiding this comment.
I don' think we should trigger another drain.
The state should be as expected before reboot, but not triggering an extra drain. See @jackfrancis 's opinion on the issue.
|
I like the idea, but I think we have details to iron out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reater than 0
closes #929