Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - KKP User Cluster Management with Terrafrom Rest API and Cluster CRDs #111

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

toschneck
Copy link
Member

@toschneck toschneck commented Nov 9, 2023

closes https://github.com/kubermatic/sig-cs-infra/issues/62

What this PR does / why we need it:

Shows the ability how KKP and Terraform could interact. The Provider is considered as example to extend it to the custom needs and cloud providers. As first example kubevirt is added

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Adding KKP REST API Terraform provider (Scope: Example Implementation to extend to custom needs)
- Adding Examples How to manage KKP User Cluster with Cluster CRDs at the seed level

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 9, 2023
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from toschneck. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 9, 2023
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 10, 2023
@toschneck toschneck changed the title WIP - KKP Terraform REST API Provider WIP - KKP User Cluster Management with Terrafrom Rest API and Cluster CRDs Nov 10, 2023

## Clustertemplate Management

Another option is to manage the [`ClusterTempalte`](https://docs.kubermatic.com/kubermatic/v2.23/references/crds/#clustertemplate) object. Therefore, a non initialized template get created and separate instance object creates a copy of it. **BUT** any change to the clustertempalte will **NOT** get applied to the instance.
Copy link
Contributor

@dharapvj dharapvj Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Another option is to manage the [`ClusterTempalte`](https://docs.kubermatic.com/kubermatic/v2.23/references/crds/#clustertemplate) object. Therefore, a non initialized template get created and separate instance object creates a copy of it. **BUT** any change to the clustertempalte will **NOT** get applied to the instance.
Another option is to manage the [`ClusterTemplate`](https://docs.kubermatic.com/kubermatic/v2.23/references/crds/#clustertemplate) object. Therefore, a non initialized template get created and separate instance object creates a copy of it. **BUT** any change to the clustertemplate will **NOT** get applied to the instance.

@dharapvj
Copy link
Contributor

dharapvj commented Nov 10, 2023

May we should add few more things via kubectl :

  1. Addon and AddonConfig CR
  2. ApplicationInstallation CR
  3. User-MLA Alerts (No CR I guess. Gets applied directly in Cortex?)
  4. User-MLA AlertManager config (AlertManager CR)

I can try to add these after your PR is merged

@toschneck toschneck self-assigned this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants