Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add valuesblock to api type used by cluster generation #6591

Merged
merged 1 commit into from Mar 8, 2024
Merged

add valuesblock to api type used by cluster generation #6591

merged 1 commit into from Mar 8, 2024

Conversation

SimonTheLeg
Copy link
Member

@SimonTheLeg SimonTheLeg commented Mar 7, 2024 •
edited

What this PR does / why we need it:

Fixes an issue where the valuesBlock field did not get rendered in the clusters' kubermatic.io/initial-application-installations-request annotation.

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2024
@SimonTheLeg SimonTheLeg force-pushed the valuesblock-in-cluster-annotation branch from 22b13d7 to 2d53282 Compare March 7, 2024 16:07
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e86e75396820b2dca09f248e3dc5d85e0cd1615c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik ahmedwaleedmalik added this to the KKP 2.25 milestone Mar 8, 2024
@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@xrstf xrstf added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Mar 8, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Mar 8, 2024
@kubermatic-bot kubermatic-bot merged commit c2e859f into kubermatic:main Mar 8, 2024
8 checks passed
@Waseem826 Waseem826 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api Denotes a PR or issue as being assigned to SIG API. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimonTheLeg @kubermatic-bot @ahmedwaleedmalik @xrstf