Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws.en.md #1569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update aws.en.md #1569

wants to merge 1 commit into from
+1 −0

Conversation

hc2p
Copy link
Contributor

@hc2p hc2p commented Nov 8, 2023

Add missing "elasticloadbalancing:AddTags" permission.

@hc2p
Update aws.en.md
971e736 
Add missing "elasticloadbalancing:AddTags" permission.

Signed-off-by: Hannes Probst <hannesprobst@gmail.com>
@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Nov 8, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign toschneck for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2023
@xrstf
Copy link
Contributor

xrstf commented Nov 9, 2023

How does this relate to #1555?

@hc2p
Copy link
Contributor Author

hc2p commented Nov 9, 2023

I was not aware of #1555 until now.
This additional permission here was needed to provision AWS ELBs from a KKP 2.23.6 installation.

@embik
Copy link
Member

embik commented Nov 15, 2023

Can you please add this to main and v2.24 for KKP docs as well?

@xrstf
Copy link
Contributor

xrstf commented Nov 15, 2023

(Note that the file is _index.en.md in those newer docs versions.)

@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2024
@xrstf
Copy link
Contributor

xrstf commented Feb 13, 2024

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2024
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2024
@xrstf xrstf removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hc2p @kubermatic-bot @xrstf @embik