Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Kubevirt incompatibility with Cilium #1597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 8, 2024

Cilium doesn't support specifying Pod's MAC address and therefore it can't be used for the KubeVirt infrastructure cluster. KubeVirt infrastructure clusters that use Cilium are not able to start VMs created by KKP/machine-controller.

Upstream reference: cilium/cilium#22119

/assign @moadqassem @embik
cc @toschneck

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Jan 8, 2024
@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xmudrii. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Jan 8, 2024

/hold
@moadqassem will confirm if it's possible to workaround this with the strict mode

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Apr 8, 2024

/remove-lifecycle stale
@moadqassem Do you have any update on this issue?

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Apr 8, 2024

Looks like this will be part of the Cilium v1.16.0 release: https://github.com/cilium/cilium/releases/tag/v1.16.0-pre.0 (cilium/cilium#29360)

@moadqassem
Copy link
Member

Looks like this will be part of the Cilium v1.16.0 release: https://github.com/cilium/cilium/releases/tag/v1.16.0-pre.0 (cilium/cilium#29360)

I haven't tried it yet. But seems that it should work. Last problem that I encountered with cilium was due to the fact of MAC address propagation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants