Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging to label step #3070

Merged
merged 1 commit into from Mar 6, 2024
Merged

add logging to label step #3070

merged 1 commit into from Mar 6, 2024

Conversation

SimonTheLeg
Copy link
Member

What this PR does / why we need it:

Adds a logging line to indicate that kubeone is starting to label nodes. Without this line I felt that error messages can sometimes be confusing. Here is an example, where label nodes failed:

INFO[16:03:22 CET] Applying addon nodelocaldns...               
WARN[16:03:24 CET] Task failed, error was: kubernetes: updating NUC-1 Node
nodes "NUC-1" not found 
WARN[16:03:34 CET] Retrying task...                             
WARN[16:03:34 CET] Task failed, error was: kubernetes: updating NUC-1 Node
nodes "NUC-1" not found

My first impression was that applying the nodelocaldns addon failed (which was not the case), because there is no mention of label nodes.

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cfd168bf4fc4eca109d0e07d416935bdc770e4da

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kron4eg
Copy link
Member

kron4eg commented Mar 6, 2024

/hold

@SimonTheLeg please rebase the PR as we've got changes in prow config and now failing job is not there anymore 🤷

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2024

/skip

@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2024

@kron4eg Shouldn't be needed to rebase
/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2024

/skip

@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2024

¯_(ツ)_/¯
/override pull-kubeone-e2e-aws-default-install-containerd-v1.25.15

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-default-install-containerd-v1.25.15

In response to this:

¯_(ツ)_/¯
/override pull-kubeone-e2e-aws-default-install-containerd-v1.25.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2024

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
xmudrii
xmudrii reviewed Mar 6, 2024
View reviewed changes
pkg/tasks/nodes.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@kron4eg
Copy link
Member

kron4eg commented Mar 6, 2024

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2024

/retest

xmudrii
xmudrii approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 6, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64b5e914df507d44624552b1ad3720b906f80622

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Mar 6, 2024 •
edited

@SimonTheLeg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubeone-e2e-aws-default-install-containerd-v1.25.15 682fe20 link true /test pull-kubeone-e2e-aws-default-install-containerd-v1.25.15

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 8b0463e into kubermatic:main Mar 6, 2024
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SimonTheLeg @kubermatic-bot @kubermatic-triage-bot @kron4eg @xmudrii @ahmedwaleedmalik