fixed cluster templates getting deleted when failing to create a clus…

…ter (#11601)
kubermatic · Dec 28, 2022 · 33f6e58 · 33f6e58
1 parent 24390da
commit 33f6e58
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/pkg/controller/seed-controller-manager/cluster-template-controller/controller.go b/pkg/controller/seed-controller-manager/cluster-template-controller/controller.go
@@ -155,16 +155,16 @@ func (r *reconciler) createClusters(ctx context.Context, instance *kubermaticv1.
 
 		for i := 0; i < int(instance.Spec.Replicas); i++ {
 			if err := r.createCluster(ctx, log, template, instance); err != nil {
-				created := int64(i + 1)
+				created := int64(i)
 				totalReplicas := instance.Spec.Replicas
 
-				if err := r.patchInstance(ctx, instance, func(i *kubermaticv1.ClusterTemplateInstance) {
+				if patchErr := r.patchInstance(ctx, instance, func(i *kubermaticv1.ClusterTemplateInstance) {
 					i.Spec.Replicas = totalReplicas - created
-				}); err != nil {
-					return err
+				}); patchErr != nil {
+					return fmt.Errorf("error patching cluster template instance (%v), after cluster creation fail: %w", patchErr, err)
 				}
 
-				return fmt.Errorf("failed to create desired number of clusters. Created %d of %d", created, totalReplicas)
+				return fmt.Errorf("failed to create desired number of clusters. Created %d of %d: %w", created, totalReplicas, err)
 			}
 		}
 	}