add version labels to deployments managed by controllers (#13176)

* add version labels to deployments managed by controllers

Signed-off-by: Simon Bein <simontheleg@gmail.com>

* review comments

Signed-off-by: Simon Bein <simontheleg@gmail.com>

---------

Signed-off-by: Simon Bein <simontheleg@gmail.com>

pkg/controller/operator/common/util.go

@@ -179,6 +179,31 @@ func VolumeRevisionLabelsModifierFactory(ctx context.Context, client ctrlruntime
 	}
 }
 
+// VersionLabelModifierFactory adds the version label for Deployments and their corresponding pods.
+func VersionLabelModifierFactory(version string) reconciling.ObjectModifier {
+	return func(create reconciling.ObjectReconciler) reconciling.ObjectReconciler {
+		return func(existing ctrlruntimeclient.Object) (ctrlruntimeclient.Object, error) {
+			obj, err := create(existing)
+			if err != nil {
+				return obj, err
+			}
+
+			deployment, ok := obj.(*appsv1.Deployment)
+			if !ok {
+				return obj, fmt.Errorf("VersionLabelModifier is only implemented for deployments, not %T", obj)
+			}
+
+			if deployment.ObjectMeta.Labels == nil {
+				deployment.ObjectMeta.Labels = make(map[string]string)
+			}
+			deployment.ObjectMeta.Labels[resources.VersionLabel] = version
+			deployment.Spec.Template.Labels[resources.VersionLabel] = version
+
+			return obj, nil
+		}
+	}
+}
+
 func createSecretData(s *corev1.Secret, data map[string]string) *corev1.Secret {
 	if s.Data == nil {
 		s.Data = make(map[string][]byte)

pkg/controller/operator/master/reconciler.go

@@ -342,6 +342,7 @@ func (r *Reconciler) reconcileDeployments(ctx context.Context, config *kubermati
 	modifiers := []reconciling.ObjectModifier{
 		common.OwnershipModifierFactory(config, r.scheme),
 		common.VolumeRevisionLabelsModifierFactory(ctx, r.Client),
+		common.VersionLabelModifierFactory(r.versions.Kubermatic),
 	}
 	// add the image pull secret wrapper only when an image pull secret is
 	// provided

pkg/controller/operator/seed/reconciler.go

@@ -569,6 +569,7 @@ func (r *Reconciler) reconcileDeployments(ctx context.Context, cfg *kubermaticv1
 	modifiers := []reconciling.ObjectModifier{
 		common.OwnershipModifierFactory(seed, r.scheme),
 		volumeLabelModifier,
+		common.VersionLabelModifierFactory(r.versions.Kubermatic),
 	}
 	// add the image pull secret wrapper only when an image pull secret is
 	// provided