review comments

Signed-off-by: Simon Bein <simontheleg@gmail.com>
kubermatic · Mar 13, 2024 · f1269aa · f1269aa
1 parent 5f3388b
commit f1269aa
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/controller/operator/common/util.go b/pkg/controller/operator/common/util.go
@@ -190,9 +190,12 @@ func VersionLabelModifierFactory(version string) reconciling.ObjectModifier {
 
 			deployment, ok := obj.(*appsv1.Deployment)
 			if !ok {
-				return obj, nil
+				return obj, fmt.Errorf("VersionLabelModifier can only be used with deployments")
 			}
 
+			if deployment.ObjectMeta.Labels == nil {
+				deployment.ObjectMeta.Labels = make(map[string]string)
+			}
 			deployment.ObjectMeta.Labels[resources.VersionLabel] = version
 			deployment.Spec.Template.Labels[resources.VersionLabel] = version