Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Installation values modification fails #6646

Open
cnvergence opened this issue Apr 11, 2024 · 0 comments · May be fixed by kubermatic/kubermatic#13276
Open

Application Installation values modification fails #6646

cnvergence opened this issue Apr 11, 2024 · 0 comments · May be fixed by kubermatic/kubermatic#13276
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/ui Denotes a PR or issue as being assigned to SIG UI.

Comments

@cnvergence
Copy link
Member

What happened

When trying to modify the Cilium app values via the dashboard, it fails the validation with the following message

admission webhook "applicationinstallations.apps.kubermatic.k8c.io" denied the request: ApplicationInstallation validation request 12db5127-e0ec-4d4f-bc04-a582bf5de1e8 denied: [spec.values.cni: Invalid value: "null": value is immutable spec.values.ipam: Invalid value: "null": value is immutable spec.values.kubeProxyReplacement: Not found: "null" spec.values.operator: Invalid value: "null": value missing or incorrect spec.values.operator.securityContext: Invalid value: "null": value is immutable]

It seems that the modifications from the dashboard are only added to valuesBlock and the values are being emptied in

dashboard/modules/api/pkg/handler/v2/application_installation/application_installation.go

Line 247 in 2babca7

ais.Values = runtime.RawExtension{}

When modifying Application Installation on that cluster directly, it works, so validation is working fine.

Expected behavior

Validation should be successful for allowed modifications via dashboard.

How to reproduce

Apply the sample from this issue kubermatic/kubermatic#12923

Environment

  • UI Version: latest
  • API Version: latest
@cnvergence cnvergence added kind/bug Categorizes issue or PR as related to a bug. sig/ui Denotes a PR or issue as being assigned to SIG UI. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. labels Apr 11, 2024
@SimonTheLeg SimonTheLeg linked a pull request Apr 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/ui Denotes a PR or issue as being assigned to SIG UI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ValuesBlock in Cilium SimonTheLeg/kubermatic
1 participant
@cnvergence