Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ValuesBlock in Cilium #13276

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use ValuesBlock in Cilium #13276

wants to merge 2 commits into from

Conversation

SimonTheLeg
Copy link
Member

What this PR does / why we need it:

Uses ValuesBlock instead of Values for Cilium. This is needed because otherwise when you change the values in the UI, the API will convert Values to ValuesBlock, but the controller will still try to populate Values, leading to an issue.

Which issue(s) this PR fixes:

Fixes #6646

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@SimonTheLeg
use ValuesBlock in Cilium
c8fb6d1 
Signed-off-by: Simon Bein <simontheleg@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/networking Denotes a PR or issue as being assigned to SIG Networking. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2024
cnvergence
cnvergence suggested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also convert these values?
https://github.com/kubermatic/kubermatic/blob/main/pkg/controller/seed-controller-manager/cni-application-installation-controller/controller.go#L366

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cnvergence, simontheleg. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2024
@SimonTheLeg
use ValuesBlock for cilium appInstall as well
0082095 
Signed-off-by: Simon Bein <simontheleg@gmail.com>
@kubermatic-bot
Copy link
Contributor

@SimonTheLeg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kubermatic-verify 0082095 link true /test pre-kubermatic-verify
pre-kubermatic-test 0082095 link true /test pre-kubermatic-test
pre-kubermatic-lint 0082095 link true /test pre-kubermatic-lint
pre-kubermatic-etcd-launcher-e2e 0082095 link true /test pre-kubermatic-etcd-launcher-e2e
pre-kubermatic-e2e-aws-ubuntu-1.28-ce 0082095 link true /test pre-kubermatic-e2e-aws-ubuntu-1.28-ce
pre-kubermatic-e2e-aws-ubuntu-1.27 0082095 link true /test pre-kubermatic-e2e-aws-ubuntu-1.27
pre-kubermatic-e2e-aws-ubuntu-1.28 0082095 link true /test pre-kubermatic-e2e-aws-ubuntu-1.28
pre-kubermatic-opa-e2e 0082095 link true /test pre-kubermatic-opa-e2e
pre-kubermatic-e2e-aws-ubuntu-1.29 0082095 link true /test pre-kubermatic-e2e-aws-ubuntu-1.29
pre-kubermatic-dualstack-e2e-aws-cilium 0082095 link true /test pre-kubermatic-dualstack-e2e-aws-cilium
pre-kubermatic-mla-e2e 0082095 link true /test pre-kubermatic-mla-e2e
pre-kubermatic-cilium-e2e 0082095 link true /test pre-kubermatic-cilium-e2e

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@embik embik added the backport-needed Denotes a PR or issue that has not been fully backported. label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnvergence cnvergence cnvergence requested changes

Assignees

@cnvergence cnvergence

Labels
backport-needed Denotes a PR or issue that has not been fully backported. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/networking Denotes a PR or issue as being assigned to SIG Networking. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application Installation values modification fails
4 participants
@SimonTheLeg @kubermatic-bot @cnvergence @embik