Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade go-git to v5.8.0 #12487

Merged
merged 1 commit into from Jul 24, 2023
Merged

upgrade go-git to v5.8.0 #12487

merged 1 commit into from Jul 24, 2023

Conversation

SimonTheLeg
Copy link
Member

@SimonTheLeg SimonTheLeg commented Jul 24, 2023 •
edited

What this PR does / why we need it:

We have experienced with Apps sometimes the issue described here go-git/go-git#328, which is supposed to be fixed in v5.8.0

Which issue(s) this PR fixes:

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix an issue in Applications, which resulted in "empty git-upload-pack given" errors for git sources

Documentation:

NONE

@SimonTheLeg
upgrade go-git to v5.8.0
abd27c9 
Signed-off-by: Simon Bein <simontheleg@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2023
@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Jul 24, 2023 •
edited

Since we are aware of the issue this dependency update is going to fix. Can we add a release note please?

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold for release note. @SimonTheLeg remove the hold once the description is updated.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a0cd667a2aaa5603e74357d5441b12f857aaf81

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, SimonTheLeg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonTheLeg,ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 24, 2023
@SimonTheLeg
Copy link
Member Author

good point with the release note. I have added one

@SimonTheLeg
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@kubermatic-bot kubermatic-bot merged commit f03412f into kubermatic:main Jul 24, 2023
11 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 24, 2023
@embik embik added the backport-needed Denotes a PR or issue that has not been fully backported. label Jul 25, 2023
This was referenced Jul 28, 2023
Merged
Merged
@pkprzekwas
Copy link
Contributor

pkprzekwas commented Jul 31, 2023 •
edited

Keep in mind that this upgrade can be affected by: #11604
To be more specific:

I didn't update go-git to 5.5.1 as they have removed the option to override the HostKeyCallback (see go-git/go-git#548), which could impact our controllers and I would rather defer this to SIG App Mngt.

@SimonTheLeg
Copy link
Member Author

@pkprzekwas I think this was re-introduced in 5.6.1

go-git/go-git#655

@xrstf
Copy link
Contributor

xrstf commented Jul 31, 2023

🎉 Awesome! :-)

@embik embik added backport-complete Denotes a PR or issue which has been fully backported to all required release branches. and removed backport-needed Denotes a PR or issue that has not been fully backported. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SimonTheLeg @ahmedwaleedmalik @kubermatic-bot @pkprzekwas @xrstf @embik