Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NVIDIA GPU operator as bundled App #13147

Merged
merged 1 commit into from Mar 5, 2024
Merged

Add NVIDIA GPU operator as bundled App #13147

merged 1 commit into from Mar 5, 2024

Conversation

SimonTheLeg
Copy link
Member

@SimonTheLeg SimonTheLeg commented Mar 1, 2024 •
edited by archups

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #13017

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add nvidia-gpu-operator to default apps

Documentation:

https://github.com/kubermatic/docs/pull/1643

@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2024
@SimonTheLeg
Copy link
Member Author

/cc @archups

ahmedwaleedmalik
ahmedwaleedmalik suggested changes Mar 4, 2024
View reviewed changes
pkg/ee/default-application-catalog/applicationdefinitions/nvidia-gpu-operator-app.yaml Outdated
@@ -0,0 +1,236 @@
# Kubermatic Enterprise Read-Only License
# Version 1.0 ("KERO-1.0”)
# Copyright © 2023 Kubermatic GmbH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2023/2024

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@SimonTheLeg
Add NVIDIA GPU operator as bundled App
5c2b2eb 
Signed-off-by: Simon Bein <simontheleg@gmail.com>
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 148235483cdabd8dbd09611b91eeff2e7c3857fe

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@SimonTheLeg
Copy link
Member Author

/retest

@xrstf xrstf added this to the KKP 2.25 milestone Mar 5, 2024
@xrstf xrstf added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Mar 5, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Mar 5, 2024
@kubermatic-bot kubermatic-bot merged commit de741dc into kubermatic:main Mar 5, 2024
17 checks passed
@archups archups mentioned this pull request Mar 12, 2024
Merged
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@archups archups Awaiting requested review from archups

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

Add Nvida Operator as default Application
4 participants
@SimonTheLeg @kubermatic-bot @ahmedwaleedmalik @xrstf