correctly identify defaulted values fields in AppInstalls #13171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Bein <simontheleg@gmail.com>
kubermatic-bot
added
docs/none
|
/milestone KKP 2.25 |
embik
approved these changes
Mar 12, 2024
|
LGTM label has been added. Git tree hash: 8e5041dd3f9dc31cb73640bbb1eb293516800b15
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
embik
added
the
code-freeze-approved
kubermatic-bot
removed
the
do-not-merge/code-freeze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I mistakenly assumed in the unit tests that "runtime.RawExtension{}" would be the same as the defaulting that k8s apiserver does. But what it actually does is unmarshal it at some point resulting in the string
{}to be used instead of it being completely empty. This updates our code and the corresponding test.Which issue(s) this PR fixes:
Fixes an issue discovered during #13096
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: