Fix missing new fields in AppDefs during KKP upgrades #13177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Bein <simontheleg@gmail.com>
kubermatic-bot
added
dco-signoff: yes
SimonTheLeg
changed the title
SimonTheLeg
changed the title
kubermatic-bot
added
the
do-not-merge/work-in-progress
xrstf
force-pushed
the
fix-appdef-missing-logo
branch
from
2fac68a
to
faa6e74
Compare
xrstf
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
xrstf
added
the
code-freeze-approved
kubermatic-bot
removed
the
do-not-merge/code-freeze
|
LGTM label has been added. Git tree hash: a814a8453dd9f5907b6a9e898bc15851b1e0ceb5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This makes the installer wait for the old webhooks to be gone before applying the AppDefs. This is important because in case of schema changes, the old mutation hooks would silently drop new fields.
Which issue(s) this PR fixes:
Fixes #13145
What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: