Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.23] Don't propagate cloud-config secret to user cluster #13373

Merged
merged 1 commit into from May 21, 2024
Merged

[release/v2.23] Don't propagate cloud-config secret to user cluster #13373

merged 1 commit into from May 21, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

This is an manual cherry-pick of #13366

Since KKP 2.23 doesn't support disabling CSI drivers, this backport has been altered and removed the logics around it.

/assign ahmedwaleedmalik

Fixes a bug where unrequired  `cloud-config` secret was being propagated to the user clusters

/kind bug

@ahmedwaleedmalik
Don't propagate cloud-config secret to user cluster (kubermatic#13366)
7c503a0 
* Don't propagate cloud-config secret to user cluster

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Fix check for cleanup

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

---------

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 2, 2024
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels May 2, 2024
@ahmedwaleedmalik
Copy link
Member Author

/cc @xrstf

@kubermatic-bot kubermatic-bot requested a review from xrstf May 2, 2024 15:01
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2024
@xrstf xrstf added the cherry-pick-approved Indicates a PR has been approved by release managers. label May 2, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 2, 2024
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-azure-ubuntu-1.27

Since Azure is back.

@ahmedwaleedmalik
Copy link
Member Author

So it's not really back, we need https://github.com/kubermatic/kubermatic/pull/13379/files

@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-azure-ubuntu-1.27

@ahmedwaleedmalik
Copy link
Member Author

cc @kubermatic/sig-release-managers

embik
embik approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f1048d58dd4d3d60504f52a35cb4721a23914c6

@xrstf
Copy link
Contributor

xrstf commented May 21, 2024

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit c60018a into kubermatic:release/v2.23 May 21, 2024
23 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the release-2.23/drop-cloud-config branch May 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@embik embik

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf @kubermatic-triage-bot @embik