Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.24] Add k8s 1.28.x to cluster-autoscaler addon manifests #13386

Open
wants to merge 1 commit into
base: release/v2.24
Choose a base branch
from
Open

[release/v2.24] Add k8s 1.28.x to cluster-autoscaler addon manifests #13386

wants to merge 1 commit into from

Conversation

akash-gautam
Copy link
Contributor

@akash-gautam akash-gautam commented May 9, 2024 •
edited

What this PR does / why we need it:
We are unable to install cluster-autoscaler addon on k8s 1.28.x clusters on KKP 2.24.x
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug
/kind regression

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add kubernetes 1.28.x support for cluster-autoscaler addon.

Documentation:

NONE

@akash-gautam
add k8s 1.28.x to cluster autoscaler addon manifests
ab2abc5 
Signed-off-by: Akash Gautam <gautamakash04@gmail.com>
@kubermatic-bot kubermatic-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 9, 2024
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone May 9, 2024
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/regression Categorizes issue or PR as related to a regression from a prior release. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2024
xrstf
xrstf approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb3014ae027481c928ef314bc6d5504ca08f5b0e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@embik
Copy link
Member

embik commented May 21, 2024

@akash-gautam before we merge this please add a release note.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 23, 2024
@embik embik added the cherry-pick-approved Indicates a PR has been approved by release managers. label May 23, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 23, 2024
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@embik
Copy link
Member

embik commented May 23, 2024

/hold

Looks like tests are broken. Probably unrelated to this PR.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@cnvergence
Copy link
Member

/retest

@kubermatic-bot
Copy link
Contributor

@akash-gautam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kubermatic-dualstack-e2e-aws-cilium ab2abc5 link true /test pre-kubermatic-dualstack-e2e-aws-cilium
pre-kubermatic-dualstack-e2e-aws-canal ab2abc5 link true /test pre-kubermatic-dualstack-e2e-aws-canal

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@akash-gautam @kubermatic-bot @embik @kubermatic-triage-bot @cnvergence @xrstf