Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes 1.30 #1777

Merged
merged 9 commits into from Apr 18, 2024
Merged

Support for Kubernetes 1.30 #1777

merged 9 commits into from Apr 18, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Apr 18, 2024 •
edited

What this PR does / why we need it:
This PR covers the following:

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

machine-controller now supports Kubernetes v1.30

Documentation:

TBD

@ahmedwaleedmalik
Update to k8s 1.30 APIs
ca87fb5 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
In-tree support has been dropped for Azure and vSphere
af22fee 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Update fixtures
0786b2d 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Default version in machine deployment examples has been raised to v1.…
8cfdda1 
…29.4

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Update fixtures
baed6d5 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Apr 18, 2024
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 18, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. label Apr 18, 2024
@ahmedwaleedmalik
Copy link
Member Author

/test all

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 18, 2024
@ahmedwaleedmalik
Disable AWS E2E tests
f74eb56 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-gce pull-machine-controller-e2e-gce-legacy-userdata

@ahmedwaleedmalik
Bump 1.28 to latest patch 1.28.9 for E2E
f901756 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Remove filter for GCE
cea8ce2 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-gce pull-machine-controller-e2e-gce-legacy-userdata

@ahmedwaleedmalik
Fix logic to populate cloud-provider and cloud-config flags
75db251 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review April 18, 2024 11:52
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@ahmedwaleedmalik
Copy link
Member Author

pull-machine-controller-e2e-kubevirt

Get "https://kubeapi.kubevirt-1.dc.k8c.io:6443/apis/kubevirt.io/v1": net/http: TLS handshake timeout

@ahmedwaleedmalik
Copy link
Member Author

ahmedwaleedmalik commented Apr 18, 2024 •
edited

pull-machine-controller-e2e-vsphere

We have lost the host where the VM template for kkp-rockylinux-8 was hosted, so this will fail for the time being.

2024-04-18T12:38:08.668Z	error	machine-controller	machine/controller.go:410	Reconciling failed	{"machine": "kube-system/rockylinux-1-29-4-vs-1780927482145280000-6b7899f97d-9ffqr", "error": "An error of type = InvalidConfiguration, with message = failed to create cloned vm: 'error when waiting for result of clone task: Unable to communicate with the remote host, since it is disconnected.' occurred"}

@xrstf
Copy link
Contributor

xrstf commented Apr 18, 2024

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-kubevirt, pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kron4eg
kron4eg approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 58ef4a31977b0120e2e61ab2caaf93cdac89132a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@kubermatic-bot kubermatic-bot merged commit f339b66 into kubermatic:main Apr 18, 2024
21 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the k8s-1.30 branch April 18, 2024 18:05
This was referenced Apr 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf @kron4eg