Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to controller-runtime 0.18 #1786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update to controller-runtime 0.18 #1786

wants to merge 1 commit into from
+91 −204

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 29, 2024 •
edited

What this PR does / why we need it:
This is purely for maintenance.

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Update to controller-runtime 0.18.2

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@ahmedwaleedmalik
Copy link
Member

/lgtm cancel

@xrstf rebase

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@xrstf
Copy link
Contributor Author

xrstf commented May 22, 2024

/retest

@xrstf xrstf force-pushed the cr-0.18 branch 2 times, most recently from 298f82f to e022357 Compare May 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik