Delete provSpec redundant check in MC providers #1791
Conversation
No need for this check in the `getConfig()` function
```
if provSpec.Value == nil {
return nil, nil, fmt.Errorf("machine.spec.providerconfig.value is nil")
}
```
because it already exists in `providerconfigtypes.GetConfig()` function
Signed-off-by: Mohamed Rafraf <81432497+mohamed-rafraf@users.noreply.github.com>
kubermatic-bot
added
docs/none
|
/assign |
kubermatic-bot
added
the
size/XS
|
Looks good. Would it be possible for you to do the same for other instances where we also have this redundant check? It should only be required here https://github.com/kubermatic/machine-controller/blob/main/pkg/providerconfig/types/types.go#L386-L388 |
kubermatic-bot
added
size/M
mohamed-rafraf
changed the title
|
LGTM label has been added. Git tree hash: dbcfdddf3a55bfaa5a239bc275ce77b4d62d906e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/retest Review the full test history Silence the bot with an |
|
/hold to avoid retries |
kubermatic-bot
added
the
do-not-merge/hold
|
@mohamed-rafraf you'll need overrides for the failing tests. @xrstf is the person to reach for that. |
|
@mohamed-rafraf: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest pull-machine-controller-e2e-azure pull-machine-controller-e2e-azure-custom-image-reference |
|
@ahmedwaleedmalik: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-machine-controller-e2e-azure pull-machine-controller-e2e-azure-custom-image-reference |
What this PR does / why we need it:
No need for this check in the
getConfig()functionbecause it already exists in
providerconfigtypes.GetConfig()functionWhich issue(s) this PR fixes:
Fixes #
What type of PR is this?
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: