update to controller-runtime 0.18.1 #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
sig/cluster-management
|
/test all |
xrstf
force-pushed
the
ctrl-runtime-0.18
branch
from
8e07698
to
1566809
Compare
|
/test all |
xrstf
force-pushed
the
ctrl-runtime-0.18
branch
from
1566809
to
2bd800b
Compare
kubermatic-bot
added
size/L
|
/test all |
xrstf
force-pushed
the
ctrl-runtime-0.18
branch
from
2bd800b
to
0bfa35d
Compare
|
/test all |
xrstf
force-pushed
the
ctrl-runtime-0.18
branch
2 times, most recently
from
fddc5e8
to
89f2eaa
Compare
kubermatic-bot
added
release-note
|
/test all |
kubermatic-bot
removed
the
do-not-merge/work-in-progress
xrstf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This bumps controller-runtime to 0.18 and takes the opportunity to clean up the OSP bootstrapping.
Previously, the default OSPs were reconciled once on OSM startup by watching Deployment creation in the
kube-systemnamespace in the worker cluster.The new code uses a channel to trigger the initial reconciliation in empty clusters. The original OSP controller would revert any OSP updates back to the version compiled into OSM, but only when a) OSM is restarted or b) a Deployment is created. So the controller is in fact reconciling like most other controllers and so is now also simply watching OSPs to reconcile unwanted changes immediately.
The reconciler also removes the ResourceVersion/Generation setting by simply not overwriting the entire OSP object (including metadata), but only overwriting its Spec when reconciling.
I also removed the duplicated OSP map (the default OSPs were both embedded and kept as a duplicate in
defaultOSPFiles) and instead parse the OSPs once upon startup and keep those objects around. The controller will now in general reconcile a little bit more than before, so not having to re-parse the YAML everytime should compensate for the additional reconcilings.What type of PR is this?
/kind cleanup
/kind chore
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: