Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote HonorReclaimPolicy to beta #1209

Merged

Conversation

carlory
Copy link
Member

@carlory carlory commented May 13, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

kubernetes/kubernetes#123151 adds e2e tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Promote HonorPVReclaimPolicy to beta.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@carlory
Copy link
Member Author

carlory commented May 13, 2024

need to update sig-storage-lib-external-provisioner dep to v10.0.0

I0513 07:13:10.887711       1 controller.go:1561] delete "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8": failed to remove finalizer for persistentvolume: persistentvolumes "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8" is forbidden: User "system:serviceaccount:default:csi-provisioner" cannot update resource "persistentvolumes" in API group "" at the cluster scope
W0513 07:13:10.887758       1 controller.go:989] Retrying syncing volume "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8", failure 0
E0513 07:13:10.887807       1 controller.go:1007] error syncing volume "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8": persistentvolumes "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8" is forbidden: User "system:serviceaccount:default:csi-provisioner" cannot update resource "persistentvolumes" in API group "" at the cluster scope

@carlory
Copy link
Member Author

carlory commented May 13, 2024

cc @jsafrane @xing-yang

@jsafrane
Copy link
Contributor

external-provisioner was updated
/retest

@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9e5a29b into kubernetes-csi:master May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants