update genproto #508
update genproto #508
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
|
|
||
| // Prefer to keep requirements compatible with the oldest supported | ||
| // k/k minor version, to prevent client backport issues. | ||
| require ( | ||
| github.com/prometheus/client_golang v1.11.1 | ||
| go.uber.org/goleak v1.2.0 | ||
| golang.org/x/net v0.7.0 // indirect |
There was a problem hiding this comment.
I'm fine with the top level go.mod changes.
Our docs currently indicate that the main line is meant for K/K 1.27+. However 1.27 go.mod show this would force an upgrade of libraries on the KAS.
Sounds like we should probably create a 0.2 (?0.28) branch to correspond the the 1.28 K/K release.
Might be worth breaking this into two PRs, so we can get the ANP binaries fixed.
There was a problem hiding this comment.
it's not urgent, we can wait for the 1.28 release, create a branch, and update both together
There was a problem hiding this comment.
#510 is resolved, and per last biweekly OSS meeting we can proceed to create a "new scheme" branch release-0.28 and cut a 0.28.x tag (in this repo).
But, k/k at release-1.28 still has older versions than what I see here, is it expected?
https://github.com/kubernetes/kubernetes/blob/release-1.28/go.mod#L91-L92
There was a problem hiding this comment.
https://github.com/kubernetes/kubernetes/pull/118269/files has the minimum genproto versions we'd want to update to here... I can pick those instead of latest (which is what pulled in the newer grpc)
There was a problem hiding this comment.
pushed an update to match versions used in k8s 1.28
does the resolution of #510 mean we would:
- create release-0.27 from master before this PR (to give a target for updates destined for k8s 1.27)
- create release-0.28 from master before this PR (to give a target for updates destined for k8s 1.28)
- merge this PR master and cherry-pick it to release-0.28
There was a problem hiding this comment.
Essentially number 1, except we'll start the new mapping scheme in 1.28.
I sent #517 to propose new branch names in the short term.
|
#510 tracks separate branching proposal. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm I created release-0.1 branch at HEAD (for 1.27 and previous), so we can begin using master branch for 1.28. Feel free to unhold when you're ready. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This updates the genproto library to a version matching kubernetes 1.28, which carves out the rpc subpackage (see googleapis/go-genproto#1015 for details)