Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pausing cluster reconcilation #1769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Karthik-K-N
Copy link
Contributor

What this PR does / why we need it:

This PR adds support for pausing a cluster reconcilation, to facilitate that it adds event filters and predicates while setting up the controller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes ##1730

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add support for pausing IBMPowerVSCluster reconcilation

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Karthik-K-N
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Karthik-K-N
Copy link
Contributor Author

/hold
Need some more testing

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2024
Copy link

netlify bot commented May 10, 2024

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 7fd342e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66431ad7b6e50f0008d68bd6
😎 Deploy Preview https://deploy-preview-1769--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Karthik-K-N Karthik-K-N force-pushed the use-pause branch 2 times, most recently from 9d0ce3f to 51d7ea1 Compare May 13, 2024 14:06
@k8s-ci-robot
Copy link
Contributor

@Karthik-K-N: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-ibmcloud-apidiff 7fd342e link false /test pull-cluster-api-provider-ibmcloud-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Karthik-K-N
Copy link
Contributor Author

Karthik-K-N commented May 14, 2024

Not able to completely test the end to end flow with create-infra workflow (I could see the machines are going into emergency mode, this is not related to this PR.
),but I could see the reconcilations being paused after adding cluster.x-k8s.io/paused: "true".
I will be trying with old workflow.

@Karthik-K-N
Copy link
Contributor Author

Tested on cluster with infra create workflow and works as expected. on setting cluster.x-k8s.io/paused: "true" on IBMPowerVSCluster resource I could see , reconcilation pausing.

I0516 08:32:51.374797       1 generic_predicates.go:191] "Resource is paused, will not attempt to map resource" predicate="ResourceNotPaused" eventType="update" namespace="default" ="capi-karthik-160511"
I0516 08:32:51.374850       1 generic_predicates.go:191] "Resource is paused, will not attempt to map resource" predicate="ResourceNotPaused" eventType="update" namespace="default" ="capi-karthik-160511"

@Karthik-K-N
Copy link
Contributor Author

Ready for review
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@mkumatag mkumatag added this to the Next milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants