🌱 Add args to golangci-lint to show lines number

[lubronzhan]

What this PR does / why we need it:
Right now the error doesn't show exact line that has issue.
With this fix, then the error log will be more descriptive.
Example: here https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/actions/runs/5791075333/job/15695267905?pr=2171

run golangci-lint
  Running [/home/runner/golangci-lint-1.53.3-linux-amd64/golangci-lint run --out-format=line-number,github-actions] in [] ...
  Error: pkg/session/session.go:335:67: unnecessary conversion (unconvert)
  		logger.V(4).Info("Session.LoginByToken with certificate", string(userCert))
  		                                                                ^
  pkg/session/session.go:347: unnecessary trailing newline (whitespace)
  
  }
  Error: unnecessary conversion (unconvert)
  Error: unnecessary trailing newline (whitespace)
  
  Error: issues found
  Ran golangci-lint in 2717ms

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes ##2058

[sbueringer]

Q: Do the PR annotations still work with this flag?

Possibly related: there was some work in golangci-lint to allow multiple format: golangci/golangci-lint-action#362 (comment) (IIRC)

[lubronzhan]

Looks like it will, now it supports several output, if output doesn't contain github-action it will append automatically.

The PR that fixed 362 actually is just adding output-format flag golangci/golangci-lint-action#769

[sbueringer]

Sounds good. Thx for looking into it.

Let's give it a try

[sbueringer]

/lgtm

/assign @killianmuldoon
@killianmuldoon once we verified it works after merge. Can you please add the same in core CAPI?

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e1558c9e02e18ca2bd1874749b501f3972503251

[killianmuldoon]

@killianmuldoon once we verified it works after merge. Can you please add the same in core CAPI?

Will do

[killianmuldoon]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment