returned objects of reference type should be unchangeable

Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
kubernetes-sigs · Mar 29, 2022 · 5c78ed8 · 5c78ed8
1 parent c46b410
commit 5c78ed8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/cache/informer_cache.go b/pkg/cache/informer_cache.go
@@ -193,8 +193,8 @@ func indexByField(indexer Informer, field string, extractor client.IndexerFunc)
 		rawVals := extractor(obj)
 		var vals []string
 		if ns == "" {
-			// if we're not doubling the keys for the namespaced case, just re-use what was returned to us
-			vals = rawVals
+			// if we're not doubling the keys for the namespaced case, just create a new slice with same length
+			vals = make([]string, len(rawVals))
 		} else {
 			// if we need to add non-namespaced versions too, double the length
 			vals = make([]string, len(rawVals)*2)