Skip to content

Commit

Permalink
🌱 update builtin webhook paths
Browse files Browse the repository at this point in the history
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
  • Loading branch information
mythi committed May 10, 2023
1 parent f7ea9c0 commit 696c28c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/builtins/mutatingwebhook.go
Expand Up @@ -26,7 +26,7 @@ import (
logf "sigs.k8s.io/controller-runtime/pkg/log"
)

// +kubebuilder:webhook:path=/mutate-v1-pod,mutating=true,failurePolicy=fail,groups="",resources=pods,verbs=create;update,versions=v1,name=mpod.kb.io
// +kubebuilder:webhook:path=/mutate--v1-pod,mutating=true,failurePolicy=fail,groups="",resources=pods,verbs=create;update,versions=v1,name=mpod.kb.io

// podAnnotator annotates Pods
type podAnnotator struct{}
Expand Down
2 changes: 1 addition & 1 deletion examples/builtins/validatingwebhook.go
Expand Up @@ -27,7 +27,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
)

// +kubebuilder:webhook:path=/validate-v1-pod,mutating=false,failurePolicy=fail,groups="",resources=pods,verbs=create;update,versions=v1,name=vpod.kb.io
// +kubebuilder:webhook:path=/validate--v1-pod,mutating=false,failurePolicy=fail,groups="",resources=pods,verbs=create;update,versions=v1,name=vpod.kb.io

This comment has been minimized.

Copy link
@camilamacedo86

camilamacedo86 Jun 14, 2023

Member

@mythi,

So the fix is add a - in the marker?
If so we must to do that in the default scaffolds I think and not in the docs.

The docs will get updated when we run make generate after the fix.

This comment has been minimized.

Copy link
@mythi

mythi Jun 14, 2023

Author Contributor

move the thread back to kubernetes-sigs/kubebuilder#3399?


// podValidator validates Pods
type podValidator struct{}
Expand Down

0 comments on commit 696c28c

Please sign in to comment.