err check

kubernetes-sigs · Apr 29, 2020 · bc38731 · bc38731
1 parent 3644686
commit bc38731
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/log/zap/flags.go b/pkg/log/zap/flags.go
@@ -110,7 +110,9 @@ func (ev *timeEncoderFlag) Set(flagValue string) error {
 	val := strings.ToLower(flagValue)
 	switch val {
 	case "iso8601", "rfc3339", "rfc3339nano", "millis", "nanos", "epoch":
-		encoder.UnmarshalText([]byte(val))
+		if err := encoder.UnmarshalText([]byte(val)); err != nil {
+			return fmt.Errorf("unable to unmarshal, \"%s\"", val)
+		}
 	default:
 		return fmt.Errorf("invalid value for time encoder, \"%s\"", val)
 	}