⚠Add ability for the delegating client to avoid caching objects #1249
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
vincepri
force-pushed
the
delegating-client-uncached
branch
2 times, most recently
from
51e0858
to
f1c36b1
Compare
Avoid caching Secrets or ConfigMaps Based on changes to the upstream controller-runtime: kubernetes-sigs/controller-runtime#1249
A long standing issue in controller runtime, the delegating client is the default client that the manager creates. Whenever a user calls Get/List on a typed object, the internal cache spins up an informer and start watching *all* objects for that group-version-kind. This change introduces the ability for the delegating client to take a list of objects that should always hit the live api-server, and bypass the cache. We also offer the ability to build a manager.NewClientFunc with a new builder that exposes the ability to mark which objects we want to be uncached. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
delegating-client-uncached
branch
from
f1c36b1
to
6089977
Compare
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
@alvaroaleman Updated with what I was thinking, it's a middle ground between both, if you still don't like it happy to just remove the builder
For some reason github doesn't allow me to respond in the thread. The builder now is fine, but please see my other comment ragarding unstructured
|
I just wanted to say thank you @vincepri for working on this. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A long standing issue in controller runtime, the delegating client is
the default client that the manager creates. Whenever a user calls
Get/List on a typed object, the internal cache spins up an informer and
start watching all objects for that group-version-kind.
This change introduces the ability for the delegating client to take
a list of objects that should always hit the live api-server, and bypass
the cache.
We also offer the ability to build a manager.NewClientFunc with a new
builder that exposes the ability to mark which objects we want to be
uncached.
Marking this as ⚠ because it changes the signature of NewDelegatingClient, which can now return an error.
/milestone v0.7.x
Related to #1222