Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 add manager.Options.WebhookServer so webhook server can be set #1500

Merged
merged 2 commits into from Apr 30, 2021

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Apr 29, 2021

This PR adds pkg/manager.Options.WebhookServer to allow external configuration of a webhook server. Currently there is no way to add a custom webhook server, since Manager.Add() will not set controllerManager.webhookServer. I am treating this as a bug since the manager's internals appear to allow external webhook configuration, but no code API was ever exposed to allow this.

/kind bug

Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com

…n of a webhook server

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2021
@estroz
Copy link
Contributor Author

estroz commented Apr 29, 2021

/cc @vincepri @alvaroaleman

@estroz
Copy link
Contributor Author

estroz commented Apr 29, 2021

There are probably a few ways to add a webhook server. This method preserves most existing logic without requiring injection, so I figured it is the easiest/forward-compatible way.

pkg/manager/manager.go Outdated Show resolved Hide resolved
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@coderanger
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@estroz estroz changed the title 🐛 pkg/manager: add Options.WebhookServer so webhook server can be set 🐛 add manager.Options.WebhookServer so webhook server can be set Apr 29, 2021
Copy link

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot
Copy link
Contributor

@cndoit18: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cndoit18, estroz, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9e04ba9 into kubernetes-sigs:master Apr 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.9.x milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants