New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 add manager.Options.WebhookServer so webhook server can be set #1500
🐛 add manager.Options.WebhookServer so webhook server can be set #1500
Conversation
…n of a webhook server Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
There are probably a few ways to add a webhook server. This method preserves most existing logic without requiring injection, so I figured it is the easiest/forward-compatible way. |
9424c04
to
9bf3306
Compare
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
9bf3306
to
c51d1ca
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@cndoit18: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cndoit18, estroz, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds
pkg/manager.Options.WebhookServer
to allow external configuration of a webhook server. Currently there is no way to add a custom webhook server, sinceManager.Add()
will not setcontrollerManager.webhookServer
. I am treating this as a bug since the manager's internals appear to allow external webhook configuration, but no code API was ever exposed to allow this./kind bug
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com