Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/olm-integration: fix example Go code for OLM < 0.17 #4945

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

estroz
Copy link
Member

@estroz estroz commented May 25, 2021

Description of the change:

  • docs/olm-integration/generation.md: fix example Go code to get webhooks working with OLM < 0.17

Motivation for the change: see kubernetes-sigs/controller-runtime#1500

/kind documentation

Checklist

If the pull request includes user-facing changes, extra documentation is required:

…ks working with OLM < 0.17

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@estroz estroz added the olm-integration Issue relates to the OLM integration label May 25, 2021
@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 25, 2021
@estroz
Copy link
Member Author

estroz commented May 25, 2021

This is waiting on stable c-r v0.9.0 to be released and supported by plugins.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2021
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@estroz estroz added the blocked label Jun 10, 2021
@estroz
Copy link
Member Author

estroz commented Jun 10, 2021

Blocked by #4977

@estroz estroz removed blocked do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 22, 2021
@estroz estroz merged commit 925f842 into operator-framework:master Jul 22, 2021
@estroz estroz deleted the docs/fix-olm-0.16-help branch July 22, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. olm-integration Issue relates to the OLM integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants