Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Add test that checks List works on UnstructuredList not in Scheme #1288

Merged
merged 1 commit into from
Dec 3, 2020
Merged

馃尡 Add test that checks List works on UnstructuredList not in Scheme #1288

merged 1 commit into from
Dec 3, 2020

Commits on Dec 3, 2020

  1. Add test that checks List works on UnstructuredList not in Scheme 

    After adding the metadata only watch and client support, the List object
was type checking on Unstructured instead of UnstructuredList.

Now! "Why were the tests passing??" one might ask, it seems that even
though our tests had some using UnstructuredLists and querying against
List, the objects we were asking (appsv1/Deployments) are core objects
that are usually included in the default client-go scheme.Scheme.

For the above reason, the internal typedClient was able to make the
request to the API server and convert the list of object back to
UnstructuredList.

Signed-off-by: Vince Prignano <vincepri@vmware.com>
    @vincepri
    vincepri committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    52ba546 View commit details
    Browse the repository at this point in the history