Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Backport bug fixes for v0.7.1 release #1329

Merged
merged 2 commits into from
Jan 11, 2021
Merged

🌱 Backport bug fixes for v0.7.1 release #1329

merged 2 commits into from
Jan 11, 2021

Commits on Jan 11, 2021

  1. 🐛 pkg/log: Set Log to NullLogger after 30 seconds 

    The delegating Logger will cause a high number of memory allocations
when no actual Logger is set. This change makes us set a NullLogger
after 30 seconds if none was set yet to avoid that.
    @alvaroaleman @vincepri
    alvaroaleman authored and vincepri committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    fd8a642 View commit details
    Browse the repository at this point in the history

  2. Do not set PatchType if patch is empty 

    In admission v1, API server requires that Patch and PatchType are both
provided or none are provided.  Meanwhile, admission v1beta1 does not
have this kind of requirement.

In controller-runtime, PatchResponseFromRaw sets PatchType regardless
of the existence of patch.  If patch is empty, a response contains
only PatchType and API server does not like it.  Webhook call fails.

This change fixes this issue by not setting PatchType if patch is
empty.
    @tatsuhiro-t @vincepri
    tatsuhiro-t authored and vincepri committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    7684ee5 View commit details
    Browse the repository at this point in the history