Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cache sync timeout functionality #1428

Merged
merged 1 commit into from
Mar 16, 2021

Commits on Mar 16, 2021

  1. 🐛 Fix cache sync timeout functionality

    So far, timing out the cache sync in most realistic scenarios didn't work,
    bceause source.Kind gets an already started cache from the Manager. A
    cache that is already started will block forever on GetInformer which we
    called in source.Kinds start and not its WaitForSync. The context passed
    to Start however defines the entire lifecycle of the Source, not the
    Start timeout.
    
    This change makes source.Kind call GetInformer in Start but in a new
    go routine and WaitForSync just wait for that to finish or for its
    context to be cancelled. This preserves the existing semantic of
    starting in Start but waint for ready in WaitForSync.
    alvaroaleman committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    4d059e8 View commit details
    Browse the repository at this point in the history