Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 don't override global log in builder #1907

Merged
merged 1 commit into from May 19, 2022
Merged

🐛 don't override global log in builder #1907

merged 1 commit into from May 19, 2022

Commits on May 18, 2022

  1. 🐛 don't override global log in builder 

    The recent change
kubernetes-sigs@598978c#diff-e77b9468ab935d5ea4d5cdae3b994114bada17df0001570e4b1436419afd50ccR312
introduced a bug by overriding `log` with the log created by a builder,
resulting in all logs produced by `controller-runtime` having
`controller`, `controllerGroup` and `controllerKind` set to the last
created controller.
    @adracus
    adracus committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a1f1aad View commit details
    Browse the repository at this point in the history