Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ feat: new features about support warning with webhook #2014

Merged
merged 13 commits into from Apr 19, 2023
Merged

⚠️ feat: new features about support warning with webhook #2014

merged 13 commits into from Apr 19, 2023

Commits on Apr 13, 2023

  1. feat: new features about support warning with webhook 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    2f57272 View commit details
    Browse the repository at this point in the history

  2. chore: refine implementing declaration, fix import cycle 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f099810 View commit details
    Browse the repository at this point in the history

  3. chore: refine interface methods declration 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    31371cc View commit details
    Browse the repository at this point in the history

  4. chore: move error as the last value returned by CustomValidatorWarn's… 

    … methods

Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    b37201d View commit details
    Browse the repository at this point in the history

  5. chore: stop using goerrors as alias or std errors 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    7d1e860 View commit details
    Browse the repository at this point in the history

  6. refactor(defaulting webhook): breaking the original interface instead… 

    … of introducing new interface

Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    9205bab View commit details
    Browse the repository at this point in the history

  7. chore: rename validator_warn_test.go to validator_test.go 

    and fix compilation errors

Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6e2a023 View commit details
    Browse the repository at this point in the history

  8. chore: append comments for modified Validator and CustomValidator 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    844f97a View commit details
    Browse the repository at this point in the history

  9. chore: address the comments 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6fe2ffd View commit details
    Browse the repository at this point in the history

  10. refactor: move and unexport FakeValidator for unit tests in admission… 

    … webhook

Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    1e1dd76 View commit details
    Browse the repository at this point in the history

  11. refactor: introduce new type as Warnings 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    8770b4d View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. chore: move fakeValidator from individual file into Validator_test.go 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    0d248e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. chore: warning message should also be carried with APIStatusError 

    Signed-off-by: STRRL <im@strrl.dev>
    @STRRL
    STRRL committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b2a9552 View commit details
    Browse the repository at this point in the history