New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 initial version of nondestructive hasLabels #2114
Conversation
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsilvela The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @jsilvela! |
Hi @jsilvela. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Closing, as issue was fixed by #2363 |
WIP - I still have stuff I want to do on this, but this initial version is non-destructive.
Todo:
HasLabels
to not silently drop invalid requirementsCloses #2098
Signed-off-by: Jaime Silvela jaime.silvela@enterprisedb.com
Fixes the problem that
HasLabels
andMatchingLabels
, applied as ListOptions, are destructive.Each will overwrite the LabelSelector with its own arguments, and the last applied wins.
This code attempts to make
HasLabels
andMatchingLabels
add as an AND, matching intuitiveexpectations when applying filters