[release-0.14] 🐛 Allow lazy restmapper to work with CRDs created at runtime #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-cherry-lazy-restmapper-fix
branch
from
fffd4f0
to
8337539
Compare
|
/test pull-controller-runtime-test-release-0-14 |
|
/retest |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Now lazy restmapper fetches all API resources once at start and then caches them. It prevents it from discovery of new CRDs created after the controller has started. This commit allows lazy restmapper to work with such CRDs.
sbueringer
force-pushed
the
pr-cherry-lazy-restmapper-fix
branch
from
8337539
to
66fe1a0
Compare
|
/assign @vincepri |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
renovate bot
added a commit
to open-feature/flagd
that referenced
this pull request
Mar 2, 2023
) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.14.4` -> `v0.14.5` | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime</summary> ### [`v0.14.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.4...v0.14.5) #### What's Changed - 🐛 Allow to set GracefulShutdownTimeout to -1, disabling timeouts in [kubernetes-sigs/controller-runtime#2198 - 🌱 GVKForObject should handle multiple GVKs in Scheme gracefully in [kubernetes-sigs/controller-runtime#2202 - ✨ Add rest client request duration and size metrics in [kubernetes-sigs/controller-runtime#2218 - 🐛 Allow lazy restmapper to work with CRDs created at runtime in [kubernetes-sigs/controller-runtime#2219 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.4...v0.14.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1My4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vihangm
pushed a commit
to newrelic/newrelic-k8s-operator
that referenced
this pull request
May 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.14.1` -> `v0.14.6` | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime</summary> ### [`v0.14.6`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.6) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.5...v0.14.6) #### What's Changed - 🐛 Preserve unstructured object GVKs when using \*ByObject cache options by [@​joelanford](https://togithub.com/joelanford) in [kubernetes-sigs/controller-runtime#2249 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.5...v0.14.6 ### [`v0.14.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.4...v0.14.5) #### What's Changed - 🐛 Allow to set GracefulShutdownTimeout to -1, disabling timeouts in [kubernetes-sigs/controller-runtime#2198 - 🌱 GVKForObject should handle multiple GVKs in Scheme gracefully in [kubernetes-sigs/controller-runtime#2202 - ✨ Add rest client request duration and size metrics in [kubernetes-sigs/controller-runtime#2218 - 🐛 Allow lazy restmapper to work with CRDs created at runtime in [kubernetes-sigs/controller-runtime#2219 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.4...v0.14.5 ### [`v0.14.4`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.4) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.3...v0.14.4) #### What's Changed - ✨ Provide a truly lazy restmapper by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2179 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.3...v0.14.4 ### [`v0.14.3`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.3) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.2...v0.14.3) #### What's Changed - ✨ Add additional SubResource\* functions for FieldOwner by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2153 - 🐛 Update golanci-lint script by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2152 - 🌱 Bump kubebuilder-release-tools to v0.3.0 by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2154 - 🌱 \[0.14] Deprecate component configuration package by [@​vincepri](https://togithub.com/vincepri) in [kubernetes-sigs/controller-runtime#2165 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.2...v0.14.3 ### [`v0.14.2`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.2) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.1...v0.14.2) #### What's Changed - \[release-0.14] 🌱 Bump k8s.io/\* to v0.26.1 by [@​sbueringer](https://togithub.com/sbueringer) in [kubernetes-sigs/controller-runtime#2146 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.1...v0.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/newrelic/newrelic-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #2208
There were conflicts in the test file. I just went with the version from main
EDIT: now resolved conflicts in a way that it works :)