Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ WIP: Cluster Provider and cluster-aware controllers #2726

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

✨ WIP: Cluster Provider and cluster-aware controllers #2726

wants to merge 9 commits into from

Conversation

sttts
Copy link

@sttts sttts commented Mar 25, 2024

Replacing #2207.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 25, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2024
mjudeikis
mjudeikis reviewed Mar 25, 2024
View reviewed changes
pkg/cluster/cluster.go Outdated Show resolved Hide resolved
mjudeikis
mjudeikis reviewed Mar 25, 2024
View reviewed changes
Copy link

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way cleaner than previous one. I like it.

pkg/builder/controller.go Outdated Show resolved Hide resolved
pkg/builder/options.go Outdated Show resolved Hide resolved
@sttts sttts force-pushed the sttts-cluster-support branch 2 times, most recently from b4891b8 to 45b458a Compare March 25, 2024 13:32
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2024
@sttts sttts force-pushed the sttts-cluster-support branch 3 times, most recently from b44fd93 to 980095c Compare March 26, 2024 10:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@sttts sttts force-pushed the sttts-cluster-support branch 2 times, most recently from e471049 to d023d3e Compare March 31, 2024 13:38
@sttts sttts mentioned this pull request Mar 31, 2024
Open
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
sbueringer
sbueringer reviewed Apr 11, 2024
View reviewed changes
pkg/builder/controller.go Outdated Show resolved Hide resolved
pkg/config/controller.go Outdated Show resolved Hide resolved
@sttts @vincepri
✨ Cluster Provider and cluster-aware controllers
3811640 
Co-authored-by: Vince Prignano <vincepri@redhat.com>
Signed-off-by: Vince Prignano <vincepri@redhat.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts sttts changed the title WIP: Cluster Provider and cluster-aware controllers ✨ WIP: Cluster Provider and cluster-aware controllers Apr 23, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
@sttts
SQUASH: fixes
ad9760b 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
SQUASH: fixes
25734fe 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
SQUASH: get rid of unused ByNameGetterFunc
ca692b1 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@sttts
SQUASH: Allow raw source
6db0f6f 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
SQUASH: cluster.{AwareRunnable -> Aware}
5bafe05 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
SQUASH: better disengage error behaviour
fc48477 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
SQUASH: add ClusterAwareSource
489224f 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
SQUASH: make manager cluster.Aware
56e0c2b 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff 56e0c2b link false /test pull-controller-runtime-apidiff
pull-controller-runtime-test 56e0c2b link true /test pull-controller-runtime-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sbueringer
sbueringer reviewed Apr 25, 2024
View reviewed changes
pkg/controller/multicluster.go
if err := ctrl.Disengage(ctx, cl); err != nil {
errs = append(errs, err)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this also:

  • loop through c.awares and call Disengage on them
  • close watches that we opened in Engage

@sttts sttts mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjudeikis mjudeikis mjudeikis left review comments

@sbueringer sbueringer sbueringer left review comments

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@vincepri vincepri Awaiting requested review from vincepri

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sttts @k8s-ci-robot @mjudeikis @sbueringer