Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.17] 🐛 Cache: Keep selectors when byObject.Namespaces is defaulted #2749

Commits on Apr 2, 2024

  1. bug: Cache: Keep selectors when byObject.Namespaces is defaulted

    Prior to this patch, configuring for example a labelSelector in
    `ByObject` and then inheriting namespaces from `DefaultNamespaces` meant
    that the `labelSelector` would be ignored. This is because if namespaces
    are configured, we set p a multinamespace cache. If we do that, we
    expect each namespace entry to have the appropriate selectors
    configured.
    
    Unfortunately we defaulted the configs for`byObject.Namespaces` before
    defaulting `byObject.Namespace` itself, causing the above-described
    issue.
    
    This change also adds a couple more tests for the cache defaulting.
    alvaroaleman authored and k8s-infra-cherrypick-robot committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    64dd305 View commit details
    Browse the repository at this point in the history