Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.17] 馃悰 prevent leader election when shutting down a non-elected manager #2752

Merged
merged 1 commit into from Apr 2, 2024
Merged

[release-0.17] 馃悰 prevent leader election when shutting down a non-elected manager #2752

merged 1 commit into from Apr 2, 2024

Commits on Apr 2, 2024

  1. 馃悰 prevent leader election when shutting down a non-elected manager 

    When leader election is enabled, a non-leader manager would never start the LeaderElection runnable group.
Thus, as the shutdown process calls the sync.Once Start func of the runnableGroup; it will start a new election.
This change ensures `Start` is ineffective during shutdown.

The test ensures the LeaderElection runnableGroup is not started during shutdown.

Signed-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>
    @alexandremahdhaoui
    alexandremahdhaoui authored and k8s-infra-cherrypick-robot committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d39bab8 View commit details
    Browse the repository at this point in the history