Merge pull request #128 from droot/running/k8s-1.13.1

🏃 upgrade k8s deps to 1.13

Gopkg.toml

@@ -14,23 +14,23 @@ required = [
 
 [[constraint]]
   name="k8s.io/api"
-  version="kubernetes-1.12.3"
+  version="kubernetes-1.13.1"
 
 [[constraint]]
   name="k8s.io/apiextensions-apiserver"
-  version="kubernetes-1.12.3"
+  version="kubernetes-1.13.1"
 
 [[constraint]]
   name="k8s.io/apimachinery"
-  version="kubernetes-1.12.3"
+  version="kubernetes-1.13.1"
 
 [[constraint]]
   name="k8s.io/code-generator"
-  version="kubernetes-1.12.3"
+  version="kubernetes-1.13.1"
 
 [[constraint]]
   name="k8s.io/client-go"
-  version="kubernetes-1.12.3"
+  version="kubernetes-1.13.1"
 
 [[constraint]]
   name = "github.com/onsi/ginkgo"

cmd/controller-gen/main.go

@@ -67,7 +67,7 @@ func newRBACCmd() *cobra.Command {
 Usage:
 # controller-gen rbac [--name manager] [--input-dir input_dir] [--output-dir output_dir]
 `,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			if err := rbac.Generate(o); err != nil {
 				log.Fatal(err)
 			}
@@ -93,7 +93,7 @@ func newCRDCmd() *cobra.Command {
 Usage:
 # controller-gen crd [--domain k8s.io] [--root-path input_dir] [--output-dir output_dir]
 `,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			if err := g.ValidateAndInitFields(); err != nil {
 				log.Fatal(err)
 			}
@@ -126,7 +126,7 @@ func newAllSubCmd() *cobra.Command {
 Usage:
 # controller-gen all
 `,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			if projectDir == "" {
 				currDir, err := os.Getwd()
 				if err != nil {
@@ -177,7 +177,7 @@ func newWebhookCmd() *cobra.Command {
 Usage:
 # controller-gen webhook [--input-dir input_dir] [--output-dir output_dir] [--patch-output-dir patch-output_dir]
 `,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			if err := webhook.Generate(o); err != nil {
 				log.Fatal(err)
 			}

cmd/crd/cmd/generate.go

@@ -40,7 +40,7 @@ exist under the root-path.
 for PROJECT file, take its path as working directory, and fetch domain info from the file.
 `,
 	Example: "crd generate --domain k8s.io",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		fmt.Println("Writing CRD files...")
 		if err := g.ValidateAndInitFields(); err != nil {
 			log.Fatal(err)

cmd/type-scaffold/main.go

@@ -45,7 +45,7 @@ Also applies the appropriate comments to generate the code required to conform t
 
 	# Generate types for a Kind called Bar with a resource of foobars
 	type-scaffold --kind Bar --resource foobars`,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			if err := opts.Validate(); err != nil {
 				return err
 			}

pkg/internal/general/util.go

@@ -67,7 +67,7 @@ func ParseDir(dir string, parseFn func(string) error) error {
 	fset := token.NewFileSet()
 
 	err := filepath.Walk(dir,
-		func(path string, info os.FileInfo, err error) error {
+		func(path string, info os.FileInfo, _ error) error {
 			if !isGoFile(info) {
 				// TODO(droot): enable this output based on verbose flag
 				// fmt.Println("skipping non-go file", path)