added pretty printing json, storing all chains, Chains type, module rename, go bump

[RinkiyaKeDad]

Signed-off-by: RinkiyaKeDad arshsharma461@gmail.com

Fixes #26, prerequisite for #24.

• Earlier we were only storing the longest chain of a particular length in a map[int][]string but with this PR we will be storing all chains of a particular length in a map[int][][]string. This is needed for create a graph that has all chains containing a specified dependency #24.
• Added tests for this change.
• Pretty printing the JSON output which was a part of this commit was not added to the original depstat repo so I've done that too in this PR.
• Introducing the Chain type which is basically a []string.
• Fixed module name in go.mod file and import in main.go.
• Bumped Go version 1.15 -> 1.16

[alenkacz]

I have a question which is not directly related to the PR but I think we should try to simplify the types there to make it more obvious for the readers if we absolutely don't need the performance of map there

[alenkacz]

I am starting to feel like these types are becoming "too much". Can we introduce some structs at least for one level of the arrays?

Actually I am checking the code now, why are we even storing the chains in map and what is that map used for? Looks like we're only writing to it and never reading from it?

depstat/cmd/utils.go

Line 51 in ae16034

chains[len(longestPath)] = longestPath

[RinkiyaKeDad]

Thanks for the review @alenkacz!

Yeah, I totally forgot about using structs 😅 I'll update the PR replacing map[int][][]string with a struct.

To answer your other question I think we will still need maps since once we have the length of the longest chain/s, maps make it easier to retrieve the actual chain/s like done here.

The way to do this without using maps would be to iterate the [][]string and print each []string which has a length equal to "the length of the longest chain/s". Maps felt a bit more convenient to me since now instead of printing a single longest chain we print all the longest chains.

If there is a better way of doing this please let me know 🙂

[alenkacz]

if you only need the longest one you can always have struct like:

type Chains struct {
 chains []Chain

 longestChainsLength int
 longestChains []Chain
}

then we could have something like

type Chain struct {
 length int
 chain []string
}

Just a quick idea. WDYT?

[RinkiyaKeDad]

This looks perfect! Thanks for this. Will update the PR tomorrow :)

[RinkiyaKeDad]

@alenkacz here's the example where we read all the longest chains from the map.

[RinkiyaKeDad]

@alenkacz looks like you were right. We didn't at all need maps for the chains. I tried converting the code to use the two structs we had discussed but that was unnecessarily introducing complications.
So instead of that I simplified everything by using a simple type Chain []string and some additional functions. PTAL 🙂

[alenkacz]

Looks great, thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, RinkiyaKeDad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RinkiyaKeDad,alenkacz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment