Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for jobset webhook updates #464

Merged

Conversation

kannon92
Copy link
Contributor

Add unit test for updates.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 1e26dc4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/660b0a01cf5af30008f5df7c

@kannon92 kannon92 force-pushed the add-update-webhook-unit-tests branch from f69c44a to f77c1e9 Compare March 21, 2024 20:45
@danielvegamyhre
Copy link
Contributor

Thanks for improving the test coverage here. Let's merge this after the complex validation PR is checked in, I think merge conflicts will be easier to resolve that way than the reverse

@kannon92
Copy link
Contributor Author

Thanks for improving the test coverage here. Let's merge this after the complex validation PR is checked in, I think merge conflicts will be easier to resolve that way than the reverse

Sounds good.

I was thinking about #463 and I was going to add unit tests for that code. Decided to move it to a separate PR so we can at least document better that elastic jobs are not supported yet.

@kannon92
Copy link
Contributor Author

/hold

Waiting on kubectl-validate code.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@kannon92 kannon92 force-pushed the add-update-webhook-unit-tests branch from f77c1e9 to 16f2f45 Compare April 1, 2024 18:54
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Apr 1, 2024

Thanks for improving the test coverage here. Let's merge this after the complex validation PR is checked in, I think merge conflicts will be easier to resolve that way than the reverse

I think we can merge this now.

@kannon92
Copy link
Contributor Author

kannon92 commented Apr 1, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@kannon92 kannon92 force-pushed the add-update-webhook-unit-tests branch from 16f2f45 to 1e26dc4 Compare April 1, 2024 19:24
@kannon92
Copy link
Contributor Author

kannon92 commented Apr 2, 2024

@danielvegamyhre I think we can get this in now. PTAL

@danielvegamyhre
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8860f83 into kubernetes-sigs:main Apr 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants