Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect Drift on NodeClaims on changes to NodeClass #1147

Merged

Conversation

engedaam
Copy link
Contributor

Fixes #337

Description

  • Detect drift on NodeClaims from when NodeClass get updated.

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2024
@coveralls
Copy link

coveralls commented Mar 31, 2024

Pull Request Test Coverage Report for Build 8560232275

Details

  • 5 of 40 (12.5%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 78.745%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 9 0.0%
pkg/controllers/nodeclaim/disruption/controller.go 5 16 31.25%
pkg/utils/nodeclaim/nodeclaim.go 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 90.63%
pkg/scheduling/requirements.go 2 97.98%
Totals Coverage Status
Change from base Build 8560206032: -0.2%
Covered Lines: 8280
Relevant Lines: 10515

💛 - Coveralls

@engedaam engedaam force-pushed the nodeclass-drift-detection branch 3 times, most recently from 800fa34 to 923b27b Compare April 1, 2024 16:41
@engedaam engedaam force-pushed the nodeclass-drift-detection branch 4 times, most recently from 347747f to 3c07006 Compare April 3, 2024 23:40
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 545d88a into kubernetes-sigs:main Apr 4, 2024
12 checks passed
@engedaam engedaam deleted the nodeclass-drift-detection branch April 14, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karpenter NodeClaim Disruption spec.nodeClassRef Drift Detection
5 participants