Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to controller-runtime v0.15.0 #420

Merged
merged 1 commit into from May 30, 2023
Merged

Upgrade to controller-runtime v0.15.0 #420

merged 1 commit into from May 30, 2023

Conversation

qbarrand
Copy link
Contributor

Remove the logger in the filter types as those functions now get a context.
Upgrade to Kubernetes v1.27.2.
Bump other dependencies.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@netlify
Copy link

netlify bot commented May 24, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit dc3ab72
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/646e0caab7ded60008dce0b3
😎 Deploy Preview https://deploy-preview-420--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@qbarrand
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 24, 2023
@qbarrand
Copy link
Contributor Author

/test all

@qbarrand
Copy link
Contributor Author

/test all

@qbarrand
Upgrade to controller-runtime v0.15.0
dc3ab72 
Remove the logger in the filter types as those functions now get a
context.
Reimplement the way we read the operator config since the
controller-runtime library code for that is deprecated.
Upgrade to Kubernetes v1.27.2.
Bump other dependencies.
@qbarrand
Copy link
Contributor Author

/test all

@qbarrand qbarrand marked this pull request as ready for review May 24, 2023 13:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
ybettan
ybettan reviewed May 28, 2023
View reviewed changes
config/manager-hub/controller_manager_config.yaml
Comment on lines -1 to -2
apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing apiVersion and kind? Doesn't it exists in the new version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We unmarshal the data ourselves, so no need for these fields anymore.

ybettan
ybettan reviewed May 28, 2023
View reviewed changes
config/manager/controller_manager_config.yaml
Comment on lines -1 to -2
apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing apiVersion and kind? Doesn't it exists in the new version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We unmarshal the data ourselves, so no need for these fields anymore.

yevgeny-shnaidman
yevgeny-shnaidman reviewed May 30, 2023
View reviewed changes
cmd/manager-hub/main.go
options := ctrl.Options{Scheme: scheme}

options, err = options.AndFrom(ctrl.ConfigFile().AtPath(configFile))
cfg, err := config.ParseFile(configFile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had the new controller-runtime version removed support for parsing option? If not, then why not use its code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has deprecated its config parser: issue, Go doc
Users are asked to move to their own config management system, this is what this PR does.

@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8c8dc55 into kubernetes-sigs:main May 30, 2023
20 checks passed
@qbarrand qbarrand deleted the kube-1.27 branch May 30, 2023 07:17
qbarrand added a commit to qbarrand/kernel-module-management that referenced this pull request Jun 2, 2023
@qbarrand
Describe how to configure the firmware lookup path (kubernetes-sigs#420)
2b230b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybettan ybettan ybettan left review comments

@yevgeny-shnaidman yevgeny-shnaidman yevgeny-shnaidman left review comments

Assignees

@yevgeny-shnaidman yevgeny-shnaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qbarrand @k8s-ci-robot @yevgeny-shnaidman @ybettan