Replace an unmaintained action #781
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Added a solution for #780, though CI failure should be unrelated. |
JohnTitor
force-pushed
the
replace-release-action
branch
from
57cdf42
to
291f536
Compare
|
@ahmetb Rebased, now ready to review! |
| echo 'RELEASE_NOTES<<EOF' >> $GITHUB_ENV | ||
| TAG=$GITHUB_REF_NAME hack/make-release-notes.sh >> $GITHUB_ENV | ||
| echo 'EOF' >> $GITHUB_ENV |
There was a problem hiding this comment.
thanks, do you mind explaining how this works. having trouble following along how we connect $GITHUB_ENV to ${{ env.RELEASE_NOTES }} below.
There was a problem hiding this comment.
See https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable.
TL;DR we can set an env var by that way (we have to pass the release notes content to create_release).
| if: contains(github.ref, 'tags') | ||
| uses: svenstaro/upload-release-action@v2 | ||
| id: create_release | ||
| uses: softprops/action-gh-release@v1 | ||
| with: |
There was a problem hiding this comment.
can we also add fail_on_unmatched_files: true (if not already set by default) as a safeguard?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, JohnTitor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The example release is here: https://github.com/2k36/krew/releases/tag/v0.100.2-rc.2
Note that the release body isn't rendered as Markdown since the latest release, opened #780 to track it.Fixed!This just replaces action with a new one, so nothing functional should have changed.
Fixes #776
Fixes #780