fix: chmod 0755 store/PLUGIN/VER dir #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
ahmetb
force-pushed
the
ahmet/fix-store-chmod
branch
2 times, most recently
from
fafb1e8
to
04a4bf0
Compare
|
Excuse my impatience. When approximately can I expect the fix and in which version will it happen? |
|
Can please someone add this |
Because we're doing `mktemp` (which gives 0700) and then moving it to `$KREW_ROOT/store/PLUGIN/VERSION`, we need to make sure that the directory is 0755 like the other dirs in `store`.
ahmetb
force-pushed
the
ahmet/fix-store-chmod
branch
from
04a4bf0
to
2ebe63b
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@ahmetb May I ask when you will bring out a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we're doing
mktemp(which gives 0700) and then moving it to$KREW_ROOT/store/PLUGIN/VERSION, we need to make sure that the directory is 0755 like the other dirs instore.See #840.