🐛 fix copyright info when has not a owner set

[camilamacedo86]

Description
Ensure that the copyright will be set when the owner is empty with the year only.

Motivation
Closes: #1620

Local Test

$ cat main.go 
/*
Copyright 2020.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

[Adirio]

I must say I don't like this new approach, as you are templating outside of the template itself. I prefered the other approach you had and by adding the dashes (-) I suggested the result would be the same but SetTemplateDefaults is left for setting defaults and the template is used for templating:

const none = `/*
{{ if .Owner -}}
Copyright {{ .Year }} {{ .Owner }}.
{{- else -}}
Copyright {{ .Year }}.
{{- end }}
*/`

[camilamacedo86]

Hi @Adirio,

Regards #1749 (comment)
I prefer as it is done because the code shows more understandable. The need to {{- is not implicit. However, both solutions are valid and I do not see a reason to block the fix because it is done in one way or another.

[Adirio]

Hi @camilamacedo86:

The usage of - is part of Go's template expecification, you can find the relevant documentation here. This pattern is used in more files over the scaffolds, it basically removes the preceding ({{-) or following (-}}) whitespaces, including new-lines.

With the approach you suggest, you are using the SetTemplateDefaults function to process part of the template, when that method is only meant to set defaults. Additionally, defaults are set at the start and templating is done at the end, in the middle some fields, for example Author may change. In that case, as you templated the copyright before, the author change would not be reflected into the scaffolded file, which would have the initial Author even if I modified it. As another tiny detail, the previous approach ({{- else -}}) requires less modifications to the current behavior (8 loc modified vs 36).

[camilamacedo86]

Hi @Adirio,

Done as you suggested.

[Adirio]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment